Add support for C23/GNU C23 standard flags#804
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/vscode-makefile-tools/sessions/29e5e236-7d7f-4f55-9195-cbcd21bb8aed Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unknown C standard control flag: c23
Add support for C23/GNU C23 standard flags
Apr 16, 2026
hanniavalera
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseCStandardincorrectly grouped C23 flags (c23,gnu23,c2x,gnu2x,iso9899:2024) with C17 flags in a single regex, mapping them all toc17/gnu17. This caused "Unknown C standard control flag: c23" andStandard: undefinedin IntelliSense configuration.The prior fix in #763 added C++23/C++26 support but missed the C standard side.
Changes
src/parser.ts— Split the combined C17/C23 regex into two distinct branches:src/util.ts— Add"c23"and"gnu23"toStandardVersiontypesrc/test/fakeSuite/extension.test.ts— Add test suite for C standard parsing (C23, C17, older)CHANGELOG.md— Add entry for [Bug] Unknown C standard control flag: c23 #803Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0psvsblobprodwus2145.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)8wdvsblobprodwus2137.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)b15vsblobprodwus2164.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install(dns block)b53vsblobprodwus2154.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)isovsblobprodwus211.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)lusvsblobprodwus2166.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install(dns block)pkwvsblobprodwus2126.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install(dns block)v41vsblobprodwus2175.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)vd2vsblobprodwus2150.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)vjmvsblobprodwus2182.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install(dns block)vm9vsblobprodwus2190.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install(dns block)wlnvsblobprodwus2188.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)y1rvsblobprodwus2136.vsblob.vsassets.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /usr/local/bin/yarn install --registry REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either: