Skip to content

Conversation

@ssreerama
Copy link
Contributor

@ssreerama ssreerama commented Dec 14, 2025

Pull Request Template – vscode-mssql

Description

This pull request adds support for generating and displaying the equivalent SqlPackage command for publishing a database project in the extension.

  • Users can now view, copy, and toggle masking of sensitive information in the generated command from the publish dialog.
  • The changes span backend service integration, request/response handling, UI updates, and localization.
  • Microsoft.Sqlpacakge.Core NuGet provides the necessary API endpoints that generates the sqlpackage command with the provided publish project details.
  • Have added few tests that covers a basic command generation scenario.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

SqlPacakgeCommandGen

@github-actions
Copy link

github-actions bot commented Dec 14, 2025

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5293 KB 5291 KB ⚪ -2 KB ( 0% )
sql-database-projects VSIX 5669 KB 5668 KB ⚪ -1 KB ( 0% )
data-workspace VSIX null KB 542 KB ⚪ 542 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 53.57143% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (2741a03) to head (4ad6cf1).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../publishProject/publishProjectWebViewController.ts 41.17% 20 Missing ⚠️
extensions/mssql/src/services/sqlPackageService.ts 40.00% 3 Missing ⚠️
extensions/mssql/src/constants/locConstants.ts 33.33% 2 Missing ⚠️
extensions/mssql/src/controllers/mainController.ts 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (53.57%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20807      +/-   ##
==========================================
- Coverage   66.65%   66.60%   -0.05%     
==========================================
  Files         210      212       +2     
  Lines       20277    20332      +55     
  Branches     2639     2650      +11     
==========================================
+ Hits        13516    13543      +27     
- Misses       6664     6692      +28     
  Partials       97       97              
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <100.00%> (ø)
...models/contracts/sqlPackage/sqlPackageContracts.ts 100.00% <100.00%> (ø)
...nsions/mssql/src/sharedInterfaces/publishDialog.ts 100.00% <100.00%> (ø)
extensions/mssql/src/sharedInterfaces/telemetry.ts 100.00% <100.00%> (ø)
extensions/mssql/src/controllers/mainController.ts 17.33% <50.00%> (+0.05%) ⬆️
extensions/mssql/src/constants/locConstants.ts 86.84% <33.33%> (-0.17%) ⬇️
extensions/mssql/src/services/sqlPackageService.ts 40.00% <40.00%> (ø)
.../publishProject/publishProjectWebViewController.ts 63.63% <41.17%> (-2.14%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ssreerama ssreerama self-assigned this Dec 31, 2025
@ssreerama ssreerama marked this pull request as ready for review January 5, 2026 20:56
@ssreerama ssreerama marked this pull request as draft January 5, 2026 20:56
@ssreerama ssreerama marked this pull request as ready for review January 8, 2026 16:54
@aasimkhan30
Copy link
Contributor

@ssreerama , please change the dropdown to searchable dropdowns. Looks and function better.

<DialogBody>
<DialogTitle
style={{
display: "flex",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Griffel stylings.

/>
</div>
</DialogTitle>
<DialogContent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if will be nice if we unify the styles and component with connection string dialog. Having a copy makes it harder to keep styles consistent.

aasimkhan30
aasimkhan30 previously approved these changes Jan 9, 2026
Copy link
Contributor

@aasimkhan30 aasimkhan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement suggestions in a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants