-
Notifications
You must be signed in to change notification settings - Fork 563
SqlPacakge command generation feature implementation for Publish Dialog #20807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Changes
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (53.57%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #20807 +/- ##
==========================================
- Coverage 66.65% 66.60% -0.05%
==========================================
Files 210 212 +2
Lines 20277 20332 +55
Branches 2639 2650 +11
==========================================
+ Hits 13516 13543 +27
- Misses 6664 6692 +28
Partials 97 97
🚀 New features to boost your workflow:
|
|
@ssreerama , please change the dropdown to searchable dropdowns. Looks and function better. |
| <DialogBody> | ||
| <DialogTitle | ||
| style={{ | ||
| display: "flex", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Griffel stylings.
| /> | ||
| </div> | ||
| </DialogTitle> | ||
| <DialogContent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if will be nice if we unify the styles and component with connection string dialog. Having a copy makes it harder to keep styles consistent.
aasimkhan30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement suggestions in a follow up PR.
Pull Request Template – vscode-mssql
Description
This pull request adds support for generating and displaying the equivalent SqlPackage command for publishing a database project in the extension.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines