Skip to content

Conversation

@lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Jan 12, 2026

Pull Request Template – vscode-mssql

Description

This PR adjusts the min column width for data columns that appear in the Edit Data grid. Previously when a data row had a lot of columns the grid would appear like this with the input box being hidden:
image

With the changes in this PR the column width is adjusted so that it's always visible.
image

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5290 KB 5290 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 542 KB ⚪ 542 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.64%. Comparing base (19c6556) to head (015bb14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20893      +/-   ##
==========================================
- Coverage   66.65%   66.64%   -0.01%     
==========================================
  Files         210      210              
  Lines       20286    20286              
  Branches     2640     2640              
==========================================
- Hits        13521    13520       -1     
  Misses       6668     6668              
- Partials       97       98       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lewis-sanchez lewis-sanchez merged commit dc256c3 into main Jan 12, 2026
3 checks passed
@lewis-sanchez lewis-sanchez deleted the lewissanchez/editData/fixColumnWidthsForFilters branch January 12, 2026 22:38
@ghiscoding
Copy link
Contributor

@lewis-sanchez I think you should reference the issue that this is supposed to close: issue #20873

I guess that now you might understand why I went with 1-2 chars in my own project.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants