Skip to content

Conversation

@ssreerama
Copy link
Contributor

Pull Request Template – vscode-mssql

Task: #20898

Description

  • Adding Icon + Header to the publish preview dialog
  • Created a common shared header component and reusing in both publish and connection dialogs.
  • Updated the changelog.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Before:
image

After:
Dark mode:
image
image

Light Mode:
image
image

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5293 KB 5295 KB ⚪ 2 KB ( 0% )
sql-database-projects VSIX 5669 KB 5669 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 543 KB ⚪ 543 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.67%. Comparing base (b1b2b41) to head (95a44ae).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20899   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files         210      210           
  Lines       20287    20287           
  Branches     2641     2641           
=======================================
  Hits        13526    13526           
  Misses       6663     6663           
  Partials       98       98           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants