chore: update to Electron 34 #237557
Draft
chore: update to Electron 34 #237557
+126
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
electron-34.x.y
branch
2 times, most recently
from
2b1d33d to
93764df
Compare
|
@deepak1556 do we need to act on this breaking change for custom protocol handlers: https://www.electronjs.org/docs/latest/breaking-changes#behavior-changed-custom-protocol-url-handling-on-windows ? |
deepak1556
force-pushed
the
electron-34.x.y
branch
3 times, most recently
from
de464b5 to
373539b
Compare
|
Thanks @bpasero , the issue only affects non standard custom schemes and data urls. The ones we use |
This reverts commit 5d4c817.
deepak1556
force-pushed
the
electron-34.x.y
branch
from
16574d2 to
a07ff54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237437