Expose shell's environment - zsh #237977
Expose shell's environment - zsh #237977
Conversation
extensions/vscode-api-tests/src/singlefolder-tests/terminal.shellIntegration.test.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh
Outdated
Show resolved
Hide resolved
|
Going through more rigorous testing, I realized sometimes (although very not expected), things like -q show up as an environment variable's value. This of course throws error. I've aimed to better handle it now, soo it skips that variable entirely. Also since hypens shouldn't really be part of variable name, we would skip the 'sending' of the variable if we detect usage of 
|
| value=$(builtin printf '%s' "${(P)var}") | ||
| # It is not valid to have hypen in variable name | ||
| # It is not valid to have hypen to start variable value | ||
| if [[ "$value" == -* || "$var" == *-* ]]; then | ||
| continue | ||
| fi | ||
| builtin printf '\e]633;EnvSingleEntry;%s;%s;%s\a' "$var" "$(__vsc_escape_value "$value")" $__vsc_nonce |
There was a problem hiding this comment.
Going through more rigorous testing, I realized sometimes (although very not expected), things like -q show up as an environment variable's value. This of course throws error. I've aimed to better handle it now, soo it skips that variable entirely.
We want to make sure this works, it sounds like we're passing the string in as a space separated list of args, rather than a single string containing spaces. Try tweaking how $value is passed to that function.
Also since hypens shouldn't really be part of variable name, we would skip the 'sending' of the variable if we detect usage of - in an environment variable name.
I don't think they're valid, but we also want to not special case this behavior either as well as it could hide obscure bugs.
There was a problem hiding this comment.
I agree, I want to avoid putting special case in update_env function and better handle this.
would something like this be better? - Adding a elif in escape_method so that I would escape it in hex similar to already existing backslashes, semi-colons, newlines.
Trying to break #228791 down smaller so that it is easier to review.
Part of #227467