-
Notifications
You must be signed in to change notification settings - Fork 37.3k
Add Collapse All action to SCM view pane
#285407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a "Collapse All" action to the SCM view pane that mimics the behavior found in the Explorer view. The action appears in the context menu when right-clicking on resource groups and intelligently collapses tree nodes in two stages: first collapsing second-level and deeper nodes, then collapsing first-level nodes only if everything below is already collapsed.
Key Changes:
- Added
CollapseAllActionclass that registers a context menu action for resource groups - Implemented
collapseAllResources()method to handle the two-stage collapse logic - Action uses the
collapseAllCodicon and appears in the 'inline' group ofMenuId.SCMResourceGroupContext
Collapse All action to SCM view pane
Collapse All action to SCM view paneCollapse All action to SCM view pane
lszomoru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. Here is some feedback:
- I think that the action should never collapse the resource group itself (that is what the twistie is for)
- I think that the action should only be shown if the resources are being shown as a tree
- Not sure about the position of the action, as it appears the leftmost action
Sounds good, let me rework this, meanwhile will move to Jan milestone. |
Pull request was converted to draft
|
@lszomoru Addressed all feedback. |
Fixes #161929