Add setting to configure agent skill locations #286265
Open
+343
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new configuration setting chat.agentSkillsLocations that allows users to specify additional folder locations to load agent skills from, beyond the default built-in locations (.github/skills, ~/.copilot/skills, .claude/skills, ~/.claude/skills).
Key changes:
- New array-type configuration setting for specifying custom agent skill folder locations
- Support for both absolute and relative paths (relative paths resolve from workspace root folders)
- Proper handling of remote environments with authority-aware URI conversion
- Comprehensive test coverage for the configuration getter function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Adds configuration schema for chat.agentSkillsLocations setting with examples and updates the chat.useAgentSkills description to reference the new setting |
| src/vs/workbench/contrib/chat/common/promptSyntax/config/config.ts | Defines the new configuration key constant and implements getAgentSkillsLocations() getter function with validation and sanitization logic |
| src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts | Integrates the new setting into skill discovery by adding findAgentSkillsInConfiguredLocations() and findAgentSkillsInFolderDirect() methods with support for absolute/relative paths and remote environments |
| src/vs/workbench/contrib/chat/test/common/promptSyntax/config/config.test.ts | Adds comprehensive test suite for getAgentSkillsLocations() covering edge cases including undefined/null values, non-array types, empty strings, whitespace trimming, and non-string filtering |
src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts
Outdated
Show resolved
Hide resolved
dmitrivMS
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.