Try publishing artifacts #286846
Try publishing artifacts #286846
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Actions workflow support for uploading Playwright trace artifacts when smoke tests fail. The changes include adding a new artifact upload step to the macOS test workflow and introducing an intentional test failure to validate the trace upload mechanism.
Key changes:
- Added Playwright trace artifact upload configuration for macOS workflow
- Introduced intentional test failure in launch.test.ts for testing purposes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/smoke/src/areas/workbench/launch.test.ts | Added intentional error to test Playwright trace generation on failure |
| .github/workflows/pr-darwin-test.yml | Added artifact upload step for Playwright traces on test failures |
| it('verifies that application launches when user data directory has non-ascii characters', async function () { | ||
| const app = this.app as Application; | ||
| await app.workbench.explorer.openExplorerView(); | ||
| throw new Error('Intentional test failure for testing Playwright traces'); |
There was a problem hiding this comment.
This intentional test failure should not be committed to the repository. This appears to be a temporary change for testing the Playwright trace artifact upload mechanism and should be removed before merging.
| throw new Error('Intentional test failure for testing Playwright traces'); |
.github/workflows/pr-darwin-test.yml
Outdated
| - name: Publish Playwright Traces | ||
| uses: actions/upload-artifact@v6 | ||
| if: failure() | ||
| continue-on-error: true | ||
| with: | ||
| name: ${{ format('playwright-traces-macos-{0}-{1}-{2}', env.VSCODE_ARCH, env.ARTIFACT_NAME, github.run_attempt) }} | ||
| path: .build/logs/**/playwright-trace-*.zip | ||
| if-no-files-found: ignore |
There was a problem hiding this comment.
The Playwright traces artifact upload step is only added to the macOS workflow but not to the Linux (pr-linux-test.yml) and Windows (pr-win32-test.yml) workflows. Since all three platforms run smoke tests with the --tracing flag enabled, they should all have consistent artifact upload configurations for Playwright traces.
|
Sad. I guess I have to give up. Ideally something like this would enable: So that you can simply open a trace directly without having to download it. But it's because GitHub Actions Artifacts requires you to be signed in to GitHub to view them, EVEN IF IT'S A PUBLIC REPO. Azure DevOps Pipeline Artifacts don't seem to have that same limitation of requiring sign in. 😢 |
No description provided.