Avoid unnecessary work when putting request into edit mode #286944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fire onDidChange to trigger a rerender to apply a css class. When onDidChange happens and the response is complete, then we update all the codeblock textmodels (?). Use an observable to avoid all this. #286660
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the shouldBeBlocked property from a plain boolean to an IObservable<boolean> to avoid unnecessary work when putting requests into edit mode. Previously, changes to this property required firing onDidChange events to trigger re-renders for applying CSS classes. By using observables, the UI can reactively update only when the property changes, eliminating unnecessary work such as updating codeblock text models when responses are complete.
Changes:
- Changed
shouldBeBlockedfrom boolean toIObservable<boolean>in interfaces and implementations - Added
setShouldBeBlocked()method toIChatRequestModelfor updating the observable value - Removed
shouldBeBlockedfrom the render key inchatWidget.tsdiffIdentityProvider - Updated
chatListRenderer.tsto useautorunfor reactive CSS class updates based on the observable
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/model/chatViewModel.ts | Updated interfaces to change shouldBeBlocked from optional boolean to IObservable<boolean> |
| src/vs/workbench/contrib/chat/common/model/chatModel.ts | Implemented observable pattern for shouldBeBlocked, added setter method, removed onDidChange event firing for this property |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Removed shouldBeBlocked from render identity calculation and updated one usage to call setShouldBeBlocked() |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Added autorun to reactively update disabled overlay CSS class based on observable changes |
Tyriar
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fire onDidChange to trigger a rerender to apply a css class. When onDidChange happens and the response is complete, then we update all the codeblock textmodels (?). Use an observable to avoid all this. #286660
fyi @justschen