Allow ghostty terminal from external terminal osx #286983
Open
+71
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Ghostty terminal application as an external terminal option on both macOS and Linux. The implementation includes platform-specific handling for launching Ghostty with proper working directory support and command execution.
Changes:
- Modified default terminal configuration to use dynamic terminal detection instead of hardcoded constant
- Added Ghostty-specific launch logic for macOS using
open -na Ghostty.app --argswith working directory flag - Added Ghostty-specific command execution logic for Linux using the
-eflag - Added unit tests for Ghostty terminal spawning on both macOS and Linux
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/externalTerminal/electron-browser/externalTerminal.contribution.ts | Updates configuration default to use dynamic terminal value from service instead of static constant |
| src/vs/platform/externalTerminal/node/externalTerminalService.ts | Implements Ghostty support for both macOS and Linux, including special handling for working directory and command execution |
| src/vs/platform/externalTerminal/test/node/externalTerminalService.test.ts | Adds tests for Ghostty spawning on macOS and Linux platforms |
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/externalTerminal/node/externalTerminalService.ts
Outdated
Show resolved
Hide resolved
anthonykim1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ghostty to launch externally for Mac! #284265
Run/debug with entry from launch.json:
Screen.Recording.2026-01-11.at.2.20.31.PM.mov