Fix determining whether cwdFolder should show on remote #286985
Draft
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix an issue with determining whether the current working directory (cwd) folder should be displayed in terminal labels for remote scenarios. The change removes the intermediate URI construction and directly compares the cwd path with the workspace folder's URI path.
Changes:
- Removes the
cwdUrivariable construction that was usingpath.resolve()on the frontend - Updates path comparison to directly compare
templateProperties.cwdwithinstance.workspaceFolder.uri.path - Adds a comment explaining the rationale for avoiding
path.resolve()in remote scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286974