disable win32 input mode by default, add exp, advanced #287015
Merged
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the win32 input mode by default and introduces a new configurable setting to control it, while also enhancing the kitty keyboard protocol setting with experiment and advanced tags.
Changes:
- Changed win32 input mode from hardcoded
trueto a configurable setting withfalseas the default - Added new
terminal.integrated.enableWin32InputModesetting with experimental and advanced tags - Enhanced
terminal.integrated.enableKittyKeyboardProtocolsetting by adding 'advanced' tag and experiment configuration
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/platform/terminal/common/terminal.ts | Added EnableWin32InputMode constant to the TerminalSettingId enum |
| src/vs/workbench/contrib/terminal/common/terminal.ts | Added enableWin32InputMode boolean property to the ITerminalConfiguration interface |
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Added configuration schema for the new EnableWin32InputMode setting and updated EnableKittyKeyboardProtocol with 'advanced' tag and experiment config |
| src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts | Updated xterm initialization and config update to use config.enableWin32InputMode instead of hardcoded true |
dmitrivMS
approved these changes
Jan 11, 2026
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #286896