fix(eslint): correct ApiEventNaming rule's broken subject detection #287049
+161
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the rule had a critical bug where it would: 1. Create unsafe regex from user input (potential regex injection) 2. Search entire file text instead of checking against known API subjects 3. Use wrong logic (parts.length < 3) that gave meaningless results Now: - Use configured subject list instead of file search - Escape regex special characters for safety - Handle multi-word subjects properly - Add configuration validation - Fix AST traversal with safety limits BREAKING CHANGE: Configuration now requires 'subjects' array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the rule had a critical bug where it would:
Now:
BREAKING CHANGE: Configuration now requires 'subjects' array