Revert "engineering: use tar+zstd for win32 node_modules cache"#291740
Merged
Revert "engineering: use tar+zstd for win32 node_modules cache"#291740
Conversation
…)" This reverts commit 7052972.
rzhao271
requested review from
TylerLeonhardt,
joaomoreno and
lszomoru
as code owners
TylerLeonhardt
approved these changes
Jan 29, 2026
pwang347
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change (PR #291624) that switched the Windows node_modules caching mechanism from 7z compression to tar+zstd compression. The revert is needed to unblock PR #291731.
Changes:
- Reverts all Windows-based Azure Pipelines and GitHub Actions workflows from tar+zstd back to 7z for node_modules caching
- Updates cache invalidation timestamp in
.cachesaltto match the pre-tar+zstd state
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build/azure-pipelines/win32/steps/product-build-win32-compile.yml | Reverts node_modules extraction and creation commands from tar+zstd to 7z |
| build/azure-pipelines/win32/product-build-win32-node-modules.yml | Reverts node_modules creation command from tar+zstd to 7z |
| build/.cachesalt | Updates cache salt timestamp to invalidate existing caches with the tar+zstd format |
| .github/workflows/pr-win32-test.yml | Reverts node_modules extraction and creation commands from tar+zstd to 7z |
| .github/workflows/pr-node-modules.yml | Reverts node_modules creation command from tar+zstd to 7z |
lszomoru
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #291624 to unblock #291731