Centralization of semicolon-delimited value handling for the multi-value control by introducing a shared codec utility#399
Open
tbernard-dennemeyer wants to merge 4 commits into
Conversation
Author
|
@microsoft-github-policy-service agree [company="Dennemeyer"] |
Author
|
@microsoft-github-policy-service agree company="Dennemeyer" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear,
This change refactors multi-value field handling to use a single shared codec so parsing and serialization are consistent across the extension.
Changed files
[valueCodec.ts]
Added shared parsing logic for semicolon-delimited values.
Added shared serialization logic that trims entries, removes empty values, and joins with semicolons.
Added compatibility helper for allowed-values behavior.
[MultiValueEvents.tsx]
Replaced inline split/trim parsing with shared codec parsing.
Replaced inline join serialization with shared codec serialization.
[getSuggestedValues.ts]
Replaced inline split/trim parsing of configured Values input with shared codec parsing.
Sample values
Input selections:
Customer A
Customer B
Serialized value:
Customer A;Customer B
Parsed result:
Customer A
Customer B
Outcome
One canonical implementation for value parsing/serialization.
Cleaner maintenance and fewer inconsistencies between read/write paths.