Skip to content

Conversation

@svasista-ms
Copy link
Contributor

@svasista-ms svasista-ms commented Aug 4, 2025

Closes #363

  • Added concurrency control to cancel in-progress jobs on the same branch
  • Added fail-fast: false to allow all jobs to complete even when some fail.

Copilot AI review requested due to automatic review settings August 4, 2025 12:57

This comment was marked as outdated.

Copy link
Collaborator

@wmmc88 wmmc88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you trigger some pipelines to ensure this is working as expected?

@svasista-ms svasista-ms changed the title ci: add concurrency control and fail-fast: false to build and test workflows ci: add concurrency control to workflows Aug 5, 2025
@svasista-ms
Copy link
Contributor Author

Could you trigger some pipelines to ensure this is working as expected?

I triggered 2 workflows with the following commits:

  • Merge remote-tracking branch 'origin/main' into ci-concurrency-control (2afb3e8)
  • test concurrency control (e1cc56a)

In-progress workflows were cancelled when a new commit was pushed. New pushes cancel workflows/jobs which are in both Queued and In Progress states. This ensures that all old workflows/jobs are cancelled upon a new event trigger.

SS before pushing test concurrency control (e1cc56a):
before

After the push:
after

@wmmc88 wmmc88 requested a review from Copilot August 5, 2025 17:53

This comment was marked as outdated.

@gurry gurry enabled auto-merge August 7, 2025 05:32
@wmmc88 wmmc88 disabled auto-merge August 7, 2025 19:59
@wmmc88 wmmc88 enabled auto-merge August 7, 2025 20:00
@wmmc88 wmmc88 disabled auto-merge August 7, 2025 21:10
@wmmc88 wmmc88 enabled auto-merge August 7, 2025 21:10
@wmmc88 wmmc88 closed this Aug 7, 2025
auto-merge was automatically disabled August 7, 2025 21:13

Pull request was closed

@wmmc88 wmmc88 reopened this Aug 7, 2025
@wmmc88 wmmc88 enabled auto-merge August 7, 2025 21:14
@wmmc88 wmmc88 disabled auto-merge August 7, 2025 23:10
@wmmc88 wmmc88 enabled auto-merge August 7, 2025 23:12
@leon-xd leon-xd disabled auto-merge August 7, 2025 23:28
@leon-xd leon-xd enabled auto-merge August 7, 2025 23:28
@wmmc88 wmmc88 disabled auto-merge August 7, 2025 23:29
@wmmc88 wmmc88 enabled auto-merge August 7, 2025 23:29
@wmmc88 wmmc88 self-requested a review August 8, 2025 00:00
@wmmc88 wmmc88 requested a review from Copilot August 8, 2025 00:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds concurrency control to GitHub Actions workflows to improve CI efficiency by canceling in-progress jobs when new commits are pushed to the same branch, while preserving all jobs on the main branch. It also enables comprehensive testing by allowing all matrix variants to complete even when some fail.

  • Added concurrency groups to cancel redundant workflow runs on feature branches
  • Implemented fail-fast: false for matrix strategies to ensure complete test coverage
  • Applied consistent formatting improvements across workflow files

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/test.yaml Added concurrency control and fail-fast configuration
.github/workflows/local-development-makefile.yaml Added concurrency control, fail-fast configuration, and moved name declaration
.github/workflows/lint.yaml Added concurrency control, fail-fast configuration, and moved name declaration
.github/workflows/github-dependency-review.yaml Added concurrency control
.github/workflows/docs.yaml Added concurrency control, fail-fast configuration, and moved name declaration
.github/workflows/codeql.yaml Added concurrency control
.github/workflows/code-formatting-check.yaml Added concurrency control
.github/workflows/cargo-audit.yaml Added concurrency control
.github/workflows/build.yaml Added concurrency control, fail-fast configuration, and moved name declaration

@wmmc88 wmmc88 disabled auto-merge August 11, 2025 22:33
@wmmc88 wmmc88 enabled auto-merge August 11, 2025 22:33
@wmmc88 wmmc88 disabled auto-merge August 11, 2025 22:33
@wmmc88 wmmc88 added this pull request to the merge queue Aug 11, 2025
@wmmc88 wmmc88 removed this pull request from the merge queue due to a manual request Aug 11, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Aug 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Aug 11, 2025
Merged via the queue into microsoft:main with commit 0090836 Aug 11, 2025
245 of 246 checks passed
@svasista-ms svasista-ms deleted the ci-concurrency-control branch November 2, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel pipelines on new push

5 participants