Skip to content

ci: expand ci matrix to test more LLVM versions #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wmmc88 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ci: expand ci matrix to test more LLVM versions #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91e6489
ci: expand ci matrix to test more LLVM versions
wmmc88 Dec 12, 2025
41c7de7
update versions to whats available on winget
wmmc88 Dec 12, 2025
266542d
remove LLVM 18 due to ARM64 bug
wmmc88 Dec 12, 2025
8ceb042
Update README.md
wmmc88 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2
Comment on lines +41 to +43
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LLVM versions added here (19.1.7, 20.1.8, 21.1.2) differ from those mentioned in the PR description (18.1.8, 19.1.1, 20.1.0, 21.1.0). The PR description states that versions 18.1.8, 19.1.1, 20.1.0, and 21.1.0 would be added, but the actual code adds 19.1.7, 20.1.8, and 21.1.2 instead. Additionally, LLVM 18 is completely omitted, which may be intentional given the README.md mentions a bug in LLVM 18 for ARM64, but this should be clarified. Please ensure the PR description accurately reflects the actual changes made.

Suggested change
- 19.1.7
- 20.1.8
- 21.1.2
# 18.1.8 is omitted due to a known bug in LLVM 18 for ARM64 (see README.md)
- 19.1.1
- 20.1.0
- 21.1.0

Copilot uses AI. Check for mistakes.

rust_toolchain:
- stable
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/codeql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2

rust_toolchain:
- stable
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2

rust_toolchain:
- stable
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2

rust_toolchain:
- stable
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/local-development-makefile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2

runs-on: ${{ matrix.runner.name }}

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:

llvm:
- 17.0.6
- 19.1.7
- 20.1.8
- 21.1.2

rust_toolchain:
- stable
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This project was built with support of WDM, KMDF, and UMDF drivers in mind, as w

* Binding generation via `bindgen` requires `libclang`. The easiest way to acquire this is via `winget`
* `winget install -i LLVM.LLVM --version 17.0.6 --force`
* See list of [tested/supported versions](https://github.com/microsoft/windows-drivers-rs/blob/main/.github/workflows/build.yaml#L39) in the [CI workflow](./.github/workflows/build.yaml)
* Ensure you select the GUI option to add LLVM to the PATH
* LLVM 18 has a bug that causes bindings to fail to generate for ARM64. Continue using LLVM 17 until LLVM 19 comes out with [the fix](https://github.com/llvm/llvm-project/pull/93235). See [this](https://github.com/rust-lang/rust-bindgen/issues/2842) for more details.
* To execute post-build tasks (ie. `inf2cat`, `infverif`, etc.), `cargo make` is used
Expand Down
Loading