-
Notifications
You must be signed in to change notification settings - Fork 110
ci: fix escaping in version-checks.yaml
#598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a breaking change in GitHub's expression parser by adding proper escaping to conditional expressions and simplifies the Winget installation process across workflow files.
Key changes:
- Added single quotes around
!cancelled()expressions in version-checks.yaml to comply with updated GitHub expression parser requirements - Replaced custom install-winget action with inline PowerShell commands using
Repair-WinGetPackageManageracross all workflow files - Removed the now-unused install-winget custom action
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/version-checks.yaml | Added single quotes around all !cancelled() conditional expressions and updated the explanatory comment |
| .github/workflows/test.yaml | Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager |
| .github/workflows/local-development-makefile.yaml | Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager |
| .github/workflows/lint.yaml | Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager |
| .github/workflows/docs.yaml | Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager |
| .github/workflows/build.yaml | Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager |
| .github/actions/install-winget/action.yaml | Deleted the entire custom action file as it's no longer needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 25 25
Lines 7135 7135
Branches 7135 7135
=======================================
Hits 5899 5899
Misses 1107 1107
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request was converted to draft
Co-authored-by: Copilot <[email protected]> Signed-off-by: Melvin Wang <[email protected]>
4aadbd5 to
6c7ddad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The workflow changes were made to fix a breaking change made to Github's expression parser (likely caused be actions/languageservices#217)