Skip to content

Conversation

@wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Dec 24, 2025

The workflow changes were made to fix a breaking change made to Github's expression parser (likely caused be actions/languageservices#217)

Copilot AI review requested due to automatic review settings December 24, 2025 00:29
@wmmc88 wmmc88 changed the title ci: fix escaping in ci: fix escaping in version-checks.yaml Dec 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a breaking change in GitHub's expression parser by adding proper escaping to conditional expressions and simplifies the Winget installation process across workflow files.

Key changes:

  • Added single quotes around !cancelled() expressions in version-checks.yaml to comply with updated GitHub expression parser requirements
  • Replaced custom install-winget action with inline PowerShell commands using Repair-WinGetPackageManager across all workflow files
  • Removed the now-unused install-winget custom action

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/version-checks.yaml Added single quotes around all !cancelled() conditional expressions and updated the explanatory comment
.github/workflows/test.yaml Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager
.github/workflows/local-development-makefile.yaml Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager
.github/workflows/lint.yaml Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager
.github/workflows/docs.yaml Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager
.github/workflows/build.yaml Replaced custom install-winget action with inline PowerShell using Repair-WinGetPackageManager
.github/actions/install-winget/action.yaml Deleted the entire custom action file as it's no longer needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.67%. Comparing base (dd8fdff) to head (1fe18af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files          25       25           
  Lines        7135     7135           
  Branches     7135     7135           
=======================================
  Hits         5899     5899           
  Misses       1107     1107           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings December 25, 2025 15:03
@wmmc88 wmmc88 marked this pull request as ready for review December 25, 2025 15:04
@wmmc88 wmmc88 enabled auto-merge December 25, 2025 15:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmmc88 wmmc88 marked this pull request as draft December 25, 2025 15:42
auto-merge was automatically disabled December 25, 2025 15:42

Pull request was converted to draft

@wmmc88 wmmc88 force-pushed the fix-version-check-escaping branch from 4aadbd5 to 6c7ddad Compare December 25, 2025 20:55
@wmmc88 wmmc88 marked this pull request as ready for review December 25, 2025 20:55
Copilot AI review requested due to automatic review settings December 25, 2025 20:55
@wmmc88 wmmc88 requested a review from a team December 25, 2025 20:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmmc88 wmmc88 enabled auto-merge December 26, 2025 23:15
@wmmc88 wmmc88 added this pull request to the merge queue Dec 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2025
@gurry gurry added this pull request to the merge queue Dec 27, 2025
Merged via the queue into microsoft:main with commit 831ab3b Dec 27, 2025
230 checks passed
@wmmc88 wmmc88 deleted the fix-version-check-escaping branch December 27, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants