Skip to content

Conversation

@gurry
Copy link
Contributor

@gurry gurry commented Dec 25, 2025

Makes it consistent with cargo and rustc. Fixes #526

to make it consistent with cargo's behaviour
Copilot AI review requested due to automatic review settings December 25, 2025 05:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves cargo-wdk's human-readable output from stdout to stderr to align with standard conventions used by cargo, rustc, and other build tools. This change enables stdout to be reserved for machine-readable output in the future and prevents output from being split across streams when redirected.

  • Configured the tracing subscriber to write to stderr instead of stdout
  • Updated all test assertions to verify output on stderr instead of stdout

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/cargo-wdk/src/trace.rs Added .with_writer(std::io::stderr) to the tracing subscriber configuration to redirect all cargo-wdk output to stderr
crates/cargo-wdk/tests/build_command_test.rs Updated test assertions to check stderr instead of stdout for cargo-wdk build output messages
crates/cargo-wdk/tests/new_command_test.rs Updated test assertions to check stderr instead of stdout for cargo-wdk new command output messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gurry gurry enabled auto-merge December 25, 2025 05:10
@gurry gurry requested a review from a team December 25, 2025 05:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.67%. Comparing base (dd8fdff) to head (9ae5782).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files          25       25           
  Lines        7135     7136    +1     
  Branches     7135     7136    +1     
=======================================
+ Hits         5899     5900    +1     
  Misses       1107     1107           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@krishnakumar4a4 krishnakumar4a4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurry gurry added this pull request to the merge queue Dec 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2025
@gurry gurry added this pull request to the merge queue Dec 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2025
@gurry gurry added this pull request to the merge queue Dec 29, 2025
Merged via the queue into microsoft:main with commit 43dc9ff Dec 29, 2025
229 checks passed
@gurry gurry deleted the move-cargo-wdk-output-to-stderr branch December 29, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move cargo-wdk output to stderr

4 participants