Skip to content

feat: add linker directive for VHF lib + move static linker directives from wdk-build to wdk-sys #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alan632 wants to merge 41 commits into
base: main
Choose a base branch
from
Open

feat: add linker directive for VHF lib + move static linker directives from wdk-build to wdk-sys #685

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
88d3948
vhf library linker directive redesign, pull out static library linker…
Jun 18, 2026
ed27cc2
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jun 18, 2026
0cce966
moved mechanism and data logic into wdk-build, wdk-sys now only selec…
Jun 18, 2026
e8756f1
Merge branch 'vhf_lib_linker_args-v2' of https://github.com/Alan632/w…
Jun 18, 2026
a3b51b8
utilize the test-stubs feature in wdk-sys to gate the new link attrib…
Jun 19, 2026
453f9db
-redesign to closely match Config::headers pattern (apisubset selecti…
Jun 19, 2026
f8f26b7
- add a cfg() conditional compilation guard on not(test)) to the link…
Jun 22, 2026
20cced8
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jun 30, 2026
f0d20e6
Addressing PR comments
Jul 2, 2026
f179fb7
Merge branch 'vhf_lib_linker_args-v2' of https://github.com/Alan632/w…
Jul 2, 2026
9e6f1c8
formatting
Jul 2, 2026
2967d71
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jul 2, 2026
8348a3f
- add new line after unsafe block in link directive return string
Jul 6, 2026
11453ac
Merge branch 'vhf_lib_linker_args-v2' of https://github.com/Alan632/w…
Jul 6, 2026
082282c
forgot to update unit tests with change to render function
Jul 6, 2026
0b5deed
toml formatting
Jul 6, 2026
d828928
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jul 20, 2026
ac529c7
- fix: naming of a couple tests for clarity
Jul 20, 2026
4f5e9a4
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jul 21, 2026
06cbdd3
Audited and refactored comments making them more succinct and removin…
Jul 21, 2026
ec66202
make a TODO comment more clear
Jul 21, 2026
b7c4f20
adding comment back in
Jul 21, 2026
219b1e3
NOT_TEST_CFG is private so shouldn't be linked in the comment
Jul 21, 2026
683ec71
also removing link in comment to `None`
Jul 21, 2026
3b15dc4
refine comments across changed files
Jul 23, 2026
6a143ac
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Jul 23, 2026
217e72b
- move implementation comment into function and refine the doc commen…
Jul 27, 2026
61c6bf9
Comment refinement
Alan632 Jul 27, 2026
d54c71d
- add a new feature to wdk-sys "no-link", where enabling "no-link" pr…
Jul 28, 2026
779e687
- remove `lto = true` from dev profiles across the repo. The dev prof…
Jul 29, 2026
8de321b
- add doc comments to test_stubs.rs
Jul 29, 2026
2b529ff
- rename the new wdk-sys feature from "no-link" to "omit-wdk-libs" du…
Jul 29, 2026
3aeb28c
- enable test-stubs in mixed-package-kmdf-workspace's driver crate
Jul 30, 2026
ad9c371
- add a step in test.yaml to run the tests for each of the sample dri…
Jul 30, 2026
71c9719
- refactor doc comments in wdk-build/lib.rs
Jul 30, 2026
b08e80b
- add WdfDriverGlobals stub to test_stubs
Jul 31, 2026
3378625
- formatting
Jul 31, 2026
aed6759
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Aug 4, 2026
d77203f
- change the new wdk-sys feature name "omit-wdk-libs" to "suppress-wd…
Aug 5, 2026
716bd64
comment formatting
Aug 6, 2026
f26ffc6
Merge branch 'main' into vhf_lib_linker_args-v2
Alan632 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,6 @@ jobs:

- name: Run Cargo Test (Top-Level tests Folder via Cargo Make)
run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }}

- name: Run Cargo Test (Top-level examples Folder via Cargo Make - Sample Drivers)
run: cargo +${{ matrix.rust_toolchain }} make --cwd ./examples test --locked --profile ${{ matrix.cargo_profile }}
1 change: 0 additions & 1 deletion crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ wdk-panic = { path = "../../../../../crates/wdk-panic" }
wdk-sys = { path = "../../../../../crates/wdk-sys" }

[profile.dev]
lto = true

[profile.release]
lto = true
1 change: 0 additions & 1 deletion crates/cargo-wdk/tests/mixed-package-kmdf-workspace/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ wdk-panic = { path = "../../../../crates/wdk-panic" }
wdk-sys = { path = "../../../../crates/wdk-sys" }

[profile.dev]
lto = true
panic = "abort"

[profile.release]
Expand Down
Loading
Loading