Add Test-EntraScript to submodules #1454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Learn Build status updates of commit 34ca9b4:
|
|
Learn Build status updates of commit b42dc47:
|
|
Learn Build status updates of commit e246bda:
|
DButoyez
reviewed
May 7, 2025
| } | ||
| } | ||
| foreach ($requiredCommand in $RequiredCommands) { | ||
| if ($requiredCommand -notin $allCommandNames) { continue } |
There was a problem hiding this comment.
Is this logic correct? should we continue when a required command is not found?
DButoyez
reviewed
May 7, 2025
| } | ||
| } | ||
| process { | ||
| if ($Path -and $Content) { |
There was a problem hiding this comment.
what happens when only path is provided?
DButoyez
reviewed
May 7, 2025
| } | ||
| } | ||
| foreach ($requiredCommand in $RequiredCommands) { | ||
| if ($requiredCommand -notin $allCommandNames) { continue } |
There was a problem hiding this comment.
Is this logic correct? should we continue when a required command is not found?
|
Resolved by #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.