Add app and SP owners and other updates (#218)

* Add app and SP owners and other updates

* PR comments

* Update with latest msgraph-metadata

generated/microsoftgraph/microsoft.graph/beta/0.1.10-preview/index.json

@@ -10,16 +10,16 @@
       "$ref": "types.json#/95"
     },
     "Microsoft.Graph/applications/federatedIdentityCredentials@beta": {
-      "$ref": "types.json#/100"
+      "$ref": "types.json#/101"
     },
     "Microsoft.Graph/oauth2PermissionGrants@beta": {
-      "$ref": "types.json#/104"
+      "$ref": "types.json#/105"
     },
     "Microsoft.Graph/appRoleAssignedTo@beta": {
-      "$ref": "types.json#/108"
+      "$ref": "types.json#/109"
     },
     "Microsoft.Graph/users@beta": {
-      "$ref": "types.json#/113"
+      "$ref": "types.json#/114"
     }
   },
   "resourceFunctions": {},
@@ -28,7 +28,7 @@
     "version": "0.1.10-preview",
     "isSingleton": false,
     "configurationType": {
-      "$ref": "types.json#/114"
+      "$ref": "types.json#/115"
     }
   }
 }

src/swagger-generation/configs/beta/0.1.10-preview.yml

@@ -146,6 +146,11 @@ EntityTypes:
       - certification
       - createdDateTime
       - publisherDomain
+    Relationships:
+      NeedsBatch: true
+      BulkLimit: 20
+      Properties:
+        - owners
   - Name: microsoft.graph.servicePrincipal
     RootUri: /servicePrincipals
     Upsertable: true
@@ -159,6 +164,11 @@ EntityTypes:
       - applicationTemplateId
       - appOwnerOrganizationId
       - signInAudience
+    Relationships:
+      NeedsBatch: true
+      BulkLimit: 20
+      Properties:
+        - owners
   - Name: microsoft.graph.federatedIdentityCredential
     RootUri: /applications/federatedIdentityCredentials
     Upsertable: true
@@ -167,7 +177,6 @@ EntityTypes:
       - audiences
       - issuer
       - name
-      - subject
   - Name: microsoft.graph.oAuth2PermissionGrant
     RootUri: /oauth2PermissionGrants
     Upsertable: false

src/swagger-generation/configs/v1.0/0.1.10-preview.yml

@@ -134,6 +134,11 @@ EntityTypes:
       - certification
       - createdDateTime
       - publisherDomain
+    Relationships:
+      NeedsBatch: true
+      BulkLimit: 20
+      Properties:
+        - owners
   - Name: microsoft.graph.servicePrincipal
     RootUri: /servicePrincipals
     Upsertable: true
@@ -144,6 +149,11 @@ EntityTypes:
       - appOwnerOrganizationId
       - resourceSpecificApplicationPermissions
       - signInAudience
+    Relationships:
+      NeedsBatch: true
+      BulkLimit: 20
+      Properties:
+        - owners
   - Name: microsoft.graph.federatedIdentityCredential
     RootUri: /applications/federatedIdentityCredentials
     Upsertable: true

src/swagger-generation/output/metadata.json

@@ -459,27 +459,67 @@
         "isIdempotent": true,
         "updatable": true,
         "alternateKey": "uniqueName",
-        "isContainment": false
+        "isContainment": false,
+        "relationshipMetadata": {
+          "needsBatch": true,
+          "bulkLimit": 20,
+          "properties": [
+            {
+              "name": "owners",
+              "type": "directoryObjects"
+            }
+          ]
+        }
       },
       "v1.0": {
         "isIdempotent": true,
         "updatable": true,
         "alternateKey": "uniqueName",
-        "isContainment": false
+        "isContainment": false,
+        "relationshipMetadata": {
+          "needsBatch": true,
+          "bulkLimit": 20,
+          "properties": [
+            {
+              "name": "owners",
+              "type": "directoryObjects"
+            }
+          ]
+        }
       }
     },
     "servicePrincipals": {
       "beta": {
         "isIdempotent": true,
         "updatable": true,
         "alternateKey": "appId",
-        "isContainment": false
+        "isContainment": false,
+        "relationshipMetadata": {
+          "needsBatch": true,
+          "bulkLimit": 20,
+          "properties": [
+            {
+              "name": "owners",
+              "type": "directoryObjects"
+            }
+          ]
+        }
       },
       "v1.0": {
         "isIdempotent": true,
         "updatable": true,
         "alternateKey": "appId",
-        "isContainment": false
+        "isContainment": false,
+        "relationshipMetadata": {
+          "needsBatch": true,
+          "bulkLimit": 20,
+          "properties": [
+            {
+              "name": "owners",
+              "type": "directoryObjects"
+            }
+          ]
+        }
       }
     },
     "applications/federatedIdentityCredentials": {

src/swagger-generation/src/deserializer.ts

@@ -317,5 +317,11 @@ const filterDescription = (description: string, isAlternateKey: boolean): string
       return !hasUnhelpfulWord && !hasReadonlyForAlternateKey;
     });
 
-  return filteredSentences.join('. ').trim();
+  // Combine all sentences and add a trailing period if not already present
+  let combinedDescription = filteredSentences.join('. ').trim();
+  if (combinedDescription && !combinedDescription.endsWith('.')) {
+    combinedDescription += '.';
+  }
+
+  return combinedDescription
 }

src/swagger-generation/tests/deserializer.test.ts

@@ -449,9 +449,9 @@ describe('constructDataStructure', () => {
     expect(propertyWithDescription).toBeDefined();
     expect(propertyWithNoDescription).toBeDefined();
     expect(altenernateKeyWithDescription).toBeDefined();
-    expect(propertyWithDescription?.Description).toBe('Description of propertyName. Optional');
+    expect(propertyWithDescription?.Description).toBe('Description of propertyName. Optional.');
     expect(propertyWithNoDescription?.Description).toBe('')
-    expect(altenernateKeyWithDescription?.Description).toBe('Alternate key of the entity. Required');
+    expect(altenernateKeyWithDescription?.Description).toBe('Alternate key of the entity. Required.');
   });
 
   it('should deserialize alternate keys', () => {