Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relationship types to Graph Bicep #217

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Add relationship types to Graph Bicep #217

merged 4 commits into from
Jan 31, 2025

Conversation

jason-dou
Copy link
Collaborator

@jason-dou jason-dou commented Jan 30, 2025 •
edited by microsoft-github-policy-service bot
Loading

  • Generate relationship types for relationship properties in Graph Bicep
  • Add configuration for the Graph Bicep extension
  • Simplify process for adding new versions. Swagger and types are generated based on the last config version
Microsoft Reviewers: Open in CodeFlow

@jason-dou jason-dou requested a review from a team as a code owner January 30, 2025 21:54
eketo-msft
eketo-msft previously approved these changes Jan 30, 2025
View reviewed changes
dkershaw10
dkershaw10 previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@dkershaw10 dkershaw10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the one comment which needs fixing.

@jason-dou jason-dou dismissed stale reviews from dkershaw10 and eketo-msft via 4d4c644 January 31, 2025 17:34
dkershaw10
dkershaw10 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@dkershaw10 dkershaw10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-dou jason-dou merged commit 8c14daf into main Jan 31, 2025
6 checks passed
@jason-dou jason-dou deleted the jasondou/relationships-types branch January 31, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkershaw10 dkershaw10 dkershaw10 approved these changes

@eketo-msft eketo-msft eketo-msft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-dou @dkershaw10 @eketo-msft