PHP 8.4 compatibility

[hubipe]

Method signatures updated to be compatible with PHP 8.4

Microsoft Reviewers: Open in CodeFlow

[rkodev]

Hi @hubipe , thank you for testing out the graph SDK, unfortunately changes to this Repo are generated by the Kiota tool and the manual changes you have added will not be reflected in the nest release. Would you like to submit a PR to kiota?

[hubipe]

@rkodev I thought that only files in the src/Generated dir are generated by Kiota. Are you sure that the file src/GraphRequestAdapter.php is generated by Kiota as well? If so, where in Kiota is this file generated?

[rkodev]

@hubipe You are right, this is a manually file, the only change we would need is to verify that sdk complies in version 8.4

[hubipe]

I've added the versions 8.3 and 8.4 to the pr-validation.yml

[baywet]

Thanks for the contribution!

[baywet]

@rkodev @hubipe I'll recap the next steps here to make sure we're all on the same page. Don't hesitate to add to this:

1. @hubipe can you replicate this PR to https://github.com/microsoftgraph/msgraph-beta-sdk-php please?
2. @hubipe can you make the promise dependency change on the kiota-php repo please? Require php-http/promise 1.3.0 to be compatible with PHP 8.4 microsoft/kiota-abstractions-php#179
3. @rkodev we'll need to merge the PR in 2 with a feat: prefix to trigger a release of the kiota dependencies
4. once the dependencies are released, we can update it in core, and release this chore(main): release 2.4.0 msgraph-sdk-php-core#211
5. once core is released, we can release here as well (and beta) after updating all dependencies

How does that sound?

[hubipe]

@baywet

1. done here – PHP 8.4 compatibility msgraph-beta-sdk-php#376
2. done here – Require php-http/promise 1.3.0 to be compatible with PHP 8.4 microsoft/kiota-php#53