middleman compatibility with 4.6 (tilt ~> 2.2)#99
Open
raccy wants to merge 2 commits intomiddleman:mainfrom
Open
middleman compatibility with 4.6 (tilt ~> 2.2)#99raccy wants to merge 2 commits intomiddleman:mainfrom
raccy wants to merge 2 commits intomiddleman:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In middleman 4.6, tilt is 2.2 or higher, but on tilt 2.2, there was a problem where render returned nil.
Upon investigation, it was found that starting from tilt 2.2, the parent class of
AsciidoctorTemplatehas been changed toStaticTemplate. InStaticTemplate, theevaluatemethod is not called during rendering; instead, rendering is completed during thepreparemethod, and only the@outputis output.To accommodate this code change, rendering is now completed solely during
prepare, and the dependency version of middleman-core has been updated.