Skip to content

Conversation

@hseeberger
Copy link
Collaborator

@hseeberger hseeberger commented May 15, 2025

Users must send their viewing key to our hosted Indexer. This PR enables to create a locally running (separate from our hosted one, also exposing an API) Wallet Indexer (the part that needs the viewing key) that gets the transactions from our hosted Indexer.

All transactions, hence need for speed. gRPC should perform much better here for our transactions which are a lot of binary data (GraphQL over Websocket needs hex-encoding). So this locally running Indexer would know all transactions and be the only component that gets the users' viewing key for these users who do not want to trust us.

@hseeberger hseeberger self-assigned this May 15, 2025
@github-actions
Copy link

github-actions bot commented May 15, 2025

Logo
Checkmarx One – Scan Summary & Detailsc35b1b8f-147a-4070-b03d-3f0042d3a936

New Issues (49)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 12
detailsWhen installing a package, its pin version should be defined
ID: wrjZpWq8T4ogdMZC3Uw2zIho%2Ffs%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 89
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: rXCy8DDo7YC%2BHelzSkEyO3N3l0U%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 93
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: qAVIR%2BXyAkXuyl5hbchGRjGNtCA%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 184
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 3ezjlYUseJZlcjRc9CraUxuUCAo%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 190
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 3Sou69FxmW%2FgRBVpVRc599I0BNo%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 178
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 8KD%2BO8hUzK1NMBoDFCyd%2BJjqlH0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 239
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: no9uLALxT8b3434CqjIhH7WkOD0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 66
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Alb6udE6uj1ZRtmRgY8cowM1q7w%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 116
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: l%2BkAasmTrSskTCcxu1BsW6yWJOg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 131
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: FJDrxODT%2FW6ywYNQad8WOgWsm8w%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 221
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 6NH%2FJvsvhrm6fphtN2dZkyT2NHw%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 120
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 9MMzc%2BSYlIpX6pEWALBrpMPKY%2FY%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 175
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Q%2Fe8Zdr8COnmZjdOYyce1I0cLT0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 226
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: jkgeW9FhrSZB7SxLwkoPEeB4jHc%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 66
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: m0GrHL8OYiDbNC1%2BDGU94OrlTFI%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 167
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: iXbRkkpWrcxzqx1wU6PQudi5So0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 83
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: kg2DK7WdgpMVGaLWKmUKrKeTS%2Bg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 210
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: RmedZYnBNTAhrRJsz4tdZi6YAwg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 208
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: ira4kToVZ4JoA2%2FmhOwVkCyH4hY%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 109
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: htDaD1lPx1mS0GqfscIcx46DQkY%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 172
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 2kTU4fbDFSjNDo4saHWi9x8tOYs%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 201
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: zIZg%2B89L7mNcyNWOcA5fKmWTI2M%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 113
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Ls19ufiGzYOvfOOcFgFtT7RQiU4%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 186
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: afgF56oJCFQL6VZZ8RGsXjUED6I%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 86
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: GA5zD3wnVoJVnwAT4UCxpC94adA%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 106
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Tz%2Foe52pzEFdLE0p7l%2FH2Ss5f%2FI%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 217
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 2BwDj6dB0CZzOuT5hsuwPYCl1ss%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 62
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: TGkf0VcNsBRjFwcPC%2FArE6ASgSg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 230
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: oe1eFhWLxs2HZoRzXaTsb%2FY2haI%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 181
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: jbHh8e%2BzDSjbLuNmN5b3RAUO7K0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 173
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: lTD26PConL84vQBFea11qg6ilmU%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 96
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: IbGhBJhfTr1JlO9QPoI9BtRVE90%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 180
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: CYziA2RLJdHZDU4q%2FqWUjiGurvg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 62
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: OMVGeQlhzTSq8BPT%2FeadELgjBZA%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 126
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: lkrUgce37q1oWjiD82FoeWeVSw0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 230
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Xik1EmcX7aDkcPbbHAZI4S%2Br1E0%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 123
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: hesDuDt7mlLqMYYteHlLffOhO%2BA%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 160
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: Fd%2BzzMB3Gifwi4k2fF0Hc28HQMM%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 138
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: zzSnqLOWuRiyjYi4Cb5aUTpvdoM%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 224
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 7a7755XXZNZQWBCkoH4Rvq4ebRs%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 129
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 4MjTj%2FFpQOVfSrE7J3GKA7GjI44%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 135
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: ikza2Ialb2uM3Tg4PPhL1zX37Wg%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 159
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: QX65XcxAX9StCisFTZTc71E7GN8%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 92
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: H7u6F2bYbv7BinRP3fp74upK3cE%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 153
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: T9zs5rF5U2PMnUzqGJB3EvPLnDk%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 166
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: DQddREnIJYpNCJLi9JYQoSfSOAo%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 134
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: FJZ%2BKMldhG7zy%2BU0sgchQ9Nn1AM%3D
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 215
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: GJgT7mlMVLQcWUClzdSX%2Bv4mpYA%3D
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 235
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: YfY7Urt6hDNFel1VQM5x1JxfCFA%3D
Fixed Issues (40)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 195
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 169
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 162
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 115
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 121
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 78
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 128
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 210
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 111
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 193
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 150
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 104
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 209
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 163
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 118
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 219
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 88
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 175
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 156
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 61
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 124
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 87
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 149
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 101
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 215
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 168
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 81
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 84
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 143
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 200
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 125
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 61
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 157
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 165
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 206
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 108
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 171
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 202
LOW Unpinned Actions Full Length Commit SHA /ci-standalone.yaml: 186
LOW Unpinned Actions Full Length Commit SHA /ci-cloud.yaml: 91

@hseeberger hseeberger force-pushed the feat/api-grpc branch 4 times, most recently from 85ec152 to 1c27cfb Compare May 18, 2025 11:26
@gilescope
Copy link
Contributor

There's a question here as to if gRPC with protobuf or scale with its metadata support. Either would be a tight binary codec. Though if we need to we could support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants