chore(ci): add automated node integration workflow #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseeberger
reviewed
Nov 11, 2025
Collaborator
hseeberger
left a comment
hseeberger
left a comment
There was a problem hiding this comment.
Does this PR also create the "node data", i.e. does it run generate-node-data.sh? If not, it needs to be extended.
| @@ -0,0 +1,31 @@ | |||
| # Node Integration Automation | |||
|
|
|||
| **Jira**: [TPM-774](https://shielded.atlassian.net/browse/TPM-774) | |||
Collaborator
There was a problem hiding this comment.
Please remoce the Jira link which is not accessible for the community; remember, this is an open source project.
|
|
||
| steps: | ||
| - name: Checkout indexer repository | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 |
Collaborator
There was a problem hiding this comment.
Does Dependabot update the comment (version number)? If not, please remove it.
| - name: Check if branch already exists | ||
| id: check_branch | ||
| run: | | ||
| BRANCH="feat/integrate-node-${{ steps.version.outputs.node_version }}" |
Collaborator
There was a problem hiding this comment.
Here comes a tricky question: Is this a feature? Or a dependency update? IMHO the answer depends ... once we support multiple node versions, e.g. 0.18 and 0.19, only supporting a new node version is a feature.
Also, do we want to automatically integrate with EVERY node release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : TPM-774
Summary
Automates creation of integration PRs when midnight-node publishes new releases.
Changes
Workflow (
.github/workflows/auto-integrate-node-release.yaml):repository_dispatchfrom midnight-node or manual workflow_dispatchDocumentation (
docs/automation/node-integration-automation.md):Testing
Related