test: Implementation to handle changed format for .node folder from X.Y.Z-<tag> to X.Y.Z #648
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariyade
reviewed
Jan 6, 2026
mariyade
approved these changes
Jan 6, 2026
GiuseppeSalvatoreShielded
approved these changes
Jan 14, 2026
….Y.Z-<tag> to X.Y.Z Updated startup-localenv-with-data.sh to handle the format change in .node directory structure: - Previously: .node/X.Y.Z-<tag>/ (e.g., .node/0.18.0-rc.11/) - Now: .node/X.Y.Z/ (e.g., .node/0.18.0/) Implementation details: - Extract base version (X.Y.Z) from NODE_TAG by removing tag suffix - Prioritize new format (.node/X.Y.Z/) first - Fallback to old format (.node/X.Y.Z-<tag>/) for backward compatibility - Provide clear error messages if neither format exists Tested scenarios: - NODE_TAG=0.18.0 → Uses .node/0.18.0/ (new format) ✓ - NODE_TAG=0.18.0-rc.11 → Uses .node/0.18.0/ (new format preferred) ✓ - Maintains backward compatibility with old format directories
THErealARETE
force-pushed
the
test/update-startup-script-with-data
branch
from
3b828d9 to
6e7bf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated startup-localenv-with-data.sh to handle the format change in .node directory structure:
Implementation details:
Tested scenarios: