Improve export options toggle label hover feedback #2669
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
If you have time, please review this PR for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small UX improvement in the Export options sheet.
In the bottom bar, the “Show this page before exporting?” text already acts as a button:
role="button".exportConfirmEnabledsetting on click.However, it previously did not show a pointer cursor on hover, making it look like plain text.
Change:
cursor: 'pointer'to the label’s inline style so that the mouse cursor reflects that it is clickable.No behavior, text, or i18n keys were changed – only visual hover feedback for an existing control.
File touched: