Skip to content

Conversation

@fare
Copy link
Collaborator

@fare fare commented Sep 8, 2025

No description provided.

@netlify
Copy link

netlify bot commented Sep 8, 2025

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 4d602e4
🔍 Latest deploy log https://app.netlify.com/projects/elastic-ritchie-8f47f9/deploys/68bea0f2706cfc0008ed0f8a
😎 Deploy Preview https://deploy-preview-1362--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, have you tested?

We really need a test suite for gxpkg....

@fare
Copy link
Collaborator Author

fare commented Sep 10, 2025

I tested minimally: it worked on my install with plenty of packages and dependencies, and tried fewer recompiles of everything. An automated test would be better, not sure the Right Way™ to do it.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lets merge for now.

Can you open an issue to make an actual testsuite?

@fare fare merged commit 7a453ba into master Sep 10, 2025
12 checks passed
@fare fare deleted the gxpkg-recurse branch September 10, 2025 07:39
@fare fare mentioned this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants