Shipwright: DockerBuildStrategy Type Migration#128
Merged
Conversation
psrvere
force-pushed
the
docker-to-buildah
branch
from
22cdba7 to
a9cb203
Compare
- For docker to buildah migration, this commit adds handling FROM field. This field is passed as "from" arg to shipwirght which then would be picked up as "--from" flag while executing buildah strategy Signed-off-by: Prateek Rathore <prathore@redhat.com> Assisted-by: Cursor
Signed-off-by: Prateek Rathore <prathore@redhat.com>
- added validaton logic Signed-off-by: Prateek Rathore <prathore@redhat.com>
Signed-off-by: Prateek Rathore <prathore@redhat.com>
Signed-off-by: Prateek Rathore <prathore@redhat.com>
- for docker to buildah strategy migration Signed-off-by: Prateek Rathore <prathore@redhat.com>
Signed-off-by: Prateek Rathore <prathore@redhat.com> Assisted-by: Cursor
Signed-off-by: Prateek Rathore <prathore@redhat.com> Assisted-by: Cursor
Signed-off-by: Prateek Rathore <prathore@redhat.com> Assited-by: Cursor
psrvere
force-pushed
the
docker-to-buildah
branch
from
53c86de to
4d61f4d
Compare
psrvere
changed the title
jmontleon
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes migration of BuildConfig's DockerBuildStrategy Type to Shipwright equivalent specs. Following is the field level status:
⬆️ Upstream RFE
Please refer to detailed notes here