Upgrade crane-lib for Job resource cleanup#556
Merged
Conversation
There was a recent change in KubernetesPlugin regarding to Job resource cleanup in migtools/crane-lib#138 Updating crane-lib dependency to get this update into crane. Related to migtools/crane-lib#138 Signed-off-by: Marek Aufart <maufart@redhat.com>
📝 WalkthroughWalkthrough
Changesgo.mod Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage ReportTotal: 46.7% Per-package coverage
Full function-level detailsPosted by CI |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 14: Verify that the pseudo-version for the github.com/konveyor/crane-lib
dependency (v0.1.6-0.20260618130404-9791be7b44bd) in go.mod corresponds to the
actual commit hash that implements the Job cleanup feature from crane-lib PR
`#138`. Check the crane-lib repository to confirm that the commit encoded in this
pseudo-version (the timestamp portion 20260618130404 and the commit hash
9791be7b44bd) matches the PR `#138` implementation before merging this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2d507fa2-1f61-45d2-afdb-12b1448c77cb
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a recent change in KubernetesPlugin regarding to Job resource cleanup in migtools/crane-lib#138
Updating crane-lib dependency to get this update into crane.
Related to migtools/crane-lib#138
Summary by CodeRabbit
crane-libdependency to latest versionpflagfrom indirect to direct dependency