-
Notifications
You must be signed in to change notification settings - Fork 8
MTA-6811, 6812, 6813, 6814, 6815, 6816 CQA April Developer Lightspeed work #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ac028e0
9ee901b
bfb6328
209ae74
e8d5f9a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,10 +16,29 @@ endif::[] | |||||
| :context: getting-started | ||||||
|
|
||||||
| [role="_abstract"] | ||||||
| The Getting started section contains information to walk you through the prerequisites, persistent volume requirements, installation, and workflows that help you to decide how you want to use {mta-dl-full}. | ||||||
| You can view prerequisites, persistent volume requirements, installation, and workflows that help you to decide how you want to use the {mta-dl-full}. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Short description should rather be structured as "Why, what". This is a user story format that we should use. Here's my suggestion:
Suggested change
|
||||||
|
|
||||||
| [NOTE] | ||||||
| ==== | ||||||
| To get support for features in {mta-dl-plugin}, you require a Red Hat Advanced Developer Suite (RHADS) subscription. | ||||||
| ==== | ||||||
|
|
||||||
| include::topics/developer-lightspeed/con_prerequisites.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/con_persistent-volumes.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/con_installation.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/proc_tackle-llm-secret.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::topics/developer-lightspeed/ref_example-code-suggestion.adoc[leveloffset=+1] | ||||||
|
|
||||||
|
|
||||||
| ifdef::parent-context-of-getting-started[:context: {parent-context-of-getting-started}] | ||||||
| ifndef::parent-context-of-getting-started[:!context:] | ||||||
|
|
||||||
| :!getting-started: | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,20 +16,18 @@ endif::[] | |||||
| :context: run-dev-lightspeed-analysis | ||||||
|
|
||||||
| [role="_abstract"] | ||||||
| After you complete the configurations, the next step is running an analysis to identify the issues in the code and generate suggestions to resolve the issues. You can get suggestions to fix code by using {mta-dl-full}. | ||||||
|
|
||||||
| When you run an analysis, {ProductShortName} displays the issues in the *Analysis Results* view. | ||||||
| After you complete the configurations, the next step is running an analysis to identify the issues in the code and generate suggestions to resolve the issues. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same why and what
Suggested change
|
||||||
|
|
||||||
| When you request code fix suggestions, {mta-dl-plugin} performs the following tasks: | ||||||
|
|
||||||
| * Streams LLM messages that describe the issue description, resolution, and the file in which the updates are applied. | ||||||
| * Streams LLM messages that describe the issue description, resolution, and the file in which {mta-dl-plugin} applies the updates. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reducing wordiness
Suggested change
|
||||||
| * Generates new files in the *Resolutions* pane. These files have the updates to the code to resolve the issues detected in the current analysis. You can review the changes, apply, or revert the updates. | ||||||
|
|
||||||
| If you apply all the resolutions, {mta-dl-plugin} applies the changes and triggers another analysis to check if there are more issues. Subsequent analysis reports fewer issues and incidents. | ||||||
|
|
||||||
| include::proc_apply-rag-resolution.adoc[leveloffset=+1] | ||||||
| include::topics/developer-lightspeed/proc_apply-rag-resolution.adoc[leveloffset=+1] | ||||||
|
|
||||||
| include::proc_running-agent-analysis.adoc[leveloffset=+1] | ||||||
| include::topics/developer-lightspeed/proc_running-agent-analysis.adoc[leveloffset=+1] | ||||||
|
|
||||||
| ifdef::parent-context-of-run-dev-lightspeed-analysis[:context: {parent-context-of-run-dev-lightspeed-analysis}] | ||||||
| ifndef::parent-context-of-run-dev-lightspeed-analysis[:!context:] | ||||||
|
|
||||||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,21 +7,21 @@ | |||||||||||
| = Debugging {mta-dl-plugin} | ||||||||||||
|
|
||||||||||||
| [role="_abstract"] | ||||||||||||
| {mta-dl-full} generates logs to debug issues specific to the extension host and the {ProductShortName} analysis and RPC server. You can also configure the log level for the {mta-dl-plugin} in the extension settings. The default log level is *debug*. | ||||||||||||
| {mta-dl-full} generates logs to debug issues specific to the extension host and the {ProductShortName} analysis and Remote Procedure Call (RPC) server. You can also configure the log level for the {mta-dl-plugin} in the extension settings. The default log level is *debug*. | ||||||||||||
|
|
||||||||||||
| Extension logs are stored as `extension.log` with automatic rotation. The maximum size of the log file is 10 MB and three files are retained. Analyzer RPC logs are stored as `analyzer.log` without rotation. | ||||||||||||
| {mta-dl-plugin} stores extension logs as `extension.log` with automatic rotation. The maximum size of the log file is 10 MB and {mta-dl-plugin} retains three files. {mta-dl-plugin} stores analyzer RPC logs as `analyzer.log` without rotation. | ||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it's not part of the short description, shall we make it a bulleted list? It improves scanability and readability. Just please check if I managed to preserve the technical accuracy when speaking about log file size and number of files.
Suggested change
|
||||||||||||
|
|
||||||||||||
| [id="dev-lightspeed-archive-logs_{context}"] | ||||||||||||
|
|
||||||||||||
| == Archiving the logs | ||||||||||||
|
|
||||||||||||
| To archive the logs as a zip file, type `{ProductShortName}: Generate Debug Archive` in the VS Code Command Palette and select the information type that must be archived as a log file. | ||||||||||||
| To archive the logs as a zip file, type `{ProductShortName}: Generate Debug Archive` in the Visual Studio Code Command Palette and select the information type to archive as a log file. | ||||||||||||
|
|
||||||||||||
| The archive command allows capturing all relevant log files in a zip archive at the specified location in your project. By default, you can access the archived logs in the .vscode directory of your project. | ||||||||||||
|
|
||||||||||||
| The archival feature helps you to save the following information: | ||||||||||||
|
|
||||||||||||
| * Large language model (LLM) provider configuration: Fields from the provider settings that can be included in the archive. All fields are redacted for security reasons by default. Ensure that you do not expose any secrets. | ||||||||||||
| * Large language model (LLM) provider configuration: Fields from the provider settings that you can include in the archive. {mta-dl-plugin} redacts all fields for security reasons by default. Ensure that you do not expose any secrets. | ||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reducing wordiness:
Suggested change
|
||||||||||||
| * LLM model arguments | ||||||||||||
| * LLM traces: If you enabled tracing LLM interactions, you can choose to include LLM traces in the logs. | ||||||||||||
|
|
||||||||||||
|
|
@@ -31,8 +31,8 @@ The archival feature helps you to save the following information: | |||||||||||
|
|
||||||||||||
| You can access the logs in the following ways: | ||||||||||||
|
|
||||||||||||
| * *Log file*: Type `Developer: Open Extension Logs Folder` and open the `redhat.mta-vscode-extension` directory that contains the extension log and the analyzer log. | ||||||||||||
| * *Log file*: Type `Developer: Open Extension Logs Folder` and open the `redhat.mta-vscode-extension` directory that has the extension log and the analyzer log. | ||||||||||||
|
|
||||||||||||
| * *Output panel*: Select `{mta-dl-plugin}` from the drop-down menu. | ||||||||||||
|
|
||||||||||||
| * *Webview logs*: You can also inspect webview content by using the webview logs. To access the webview logs, type `Open Webview Developer Tools` in the VS Code Command Palette. | ||||||||||||
| * *Webview logs*: You can also inspect webview content by using the webview logs. To access the webview logs, type `Open Webview Developer Tools` in the Visual Studio Code Command Palette. | ||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Provide" in this context sounds a bit better than "give". We have no strict rule that prohibits using "provide". it's rather a minimalism concern that must not necessarily be changed. Especially, when it sounds better :-) Here's my suggestion to also reduce wordiness: