WIP MTA-6889 CLI refactored commands#372
Conversation
📝 WalkthroughWalkthroughThe CLI guide gains a new assembly page and several AsciiDoc topics covering the reorganized ChangesMTA CLI guide documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/topics/mta-cli/ref_deprecated-commands-and-options.adoc (1)
46-48: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAvoid publishing an empty “Additional resources” section.
Line 46–48 introduces the section header but no links/resources follow. Please either add at least one resource or remove the empty section.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/topics/mta-cli/ref_deprecated-commands-and-options.adoc` around lines 46 - 48, The “Additional resources” section is empty, so either add at least one relevant resource link under the .Additional resources heading or remove the section entirely from the deprecated commands and options topic; update the AsciiDoc block around the Additional resources anchor/header so it only appears when actual content is present.assemblies/cli-guide/assembly_about-the-command-line-tool.adoc (1)
22-24: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winAssembly ends without including topic modules.
Line 22–24 closes context, but the assembly never includes the concept/reference modules. This leaves the page with only the title/abstract and omits the CLI content this PR adds.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@assemblies/cli-guide/assembly_about-the-command-line-tool.adoc` around lines 22 - 24, The assembly currently only sets and clears context in the about-the-command-line-tool page, so it never pulls in the new CLI content. Update the assembly to include the relevant concept/reference topic modules used by this PR, placing them in the proper section of the assembly so the content renders after the title and abstract. Use the assembly document structure around the parent-context-of-about-the-command-line-tool markers to locate where the missing module includes should be added.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/topics/mta-cli/ref_provider-and-rules-command-options.adoc`:
- Around line 23-35: The provider command examples and their placeholder
definitions use hyphenated placeholder names, which should be converted to
underscore-separated placeholders to match repo conventions. Update the AsciiDoc
in the provider install/remove examples so the command examples and the
corresponding “where” definitions both use the same underscore-form placeholder
name, and keep the wording consistent across the install and remove sections.
---
Outside diff comments:
In `@assemblies/cli-guide/assembly_about-the-command-line-tool.adoc`:
- Around line 22-24: The assembly currently only sets and clears context in the
about-the-command-line-tool page, so it never pulls in the new CLI content.
Update the assembly to include the relevant concept/reference topic modules used
by this PR, placing them in the proper section of the assembly so the content
renders after the title and abstract. Use the assembly document structure around
the parent-context-of-about-the-command-line-tool markers to locate where the
missing module includes should be added.
In `@docs/topics/mta-cli/ref_deprecated-commands-and-options.adoc`:
- Around line 46-48: The “Additional resources” section is empty, so either add
at least one relevant resource link under the .Additional resources heading or
remove the section entirely from the deprecated commands and options topic;
update the AsciiDoc block around the Additional resources anchor/header so it
only appears when actual content is present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fce97313-4a4b-4054-b5b9-d6917358090f
📒 Files selected for processing (5)
assemblies/cli-guide/assembly_about-the-command-line-tool.adocdocs/topics/mta-cli/con_cli-command-structure.adocdocs/topics/mta-cli/ref_backward-compatibility.adocdocs/topics/mta-cli/ref_deprecated-commands-and-options.adocdocs/topics/mta-cli/ref_provider-and-rules-command-options.adoc
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
a36333f to
60bdb23
Compare
JIRA
Version
Previews
Summary by CodeRabbit
mta-cli provider listandmta-cli rules list-targets) and removed outdatedtransform openrewritereferences.mta-cli analyzeflag documentation by removing listing flags moved torules/provider.