Add tests#3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the non-admin directory and adds comprehensive integration tests for the CLI. Key changes include updates to module and import paths, addition of new test files and utilities, and reorganization of non-admin backup commands.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/* | New test files for CLI commands, build processes, and documentation |
| main.go, go.mod | Updated module and import paths to match the new repository structure |
| cmd/* | Updated non-admin command implementations and restructured backup commands |
| .github/workflows/* | Added CI configurations for tests and linting |
Comments suppressed due to low confidence (1)
cmd/non-admin/backup/nonadminbackup_builder.go:17
- The file name 'nonadminbackup_builder.go' is inconsistent with the package name 'backup'. Consider renaming the file to 'backup_builder.go' for clarity and consistency.
package backup
There was a problem hiding this comment.
Thank you for adding comprehensive testing infrastructure to the project! The test structure is well-organized and the CI/CD workflows are a great addition. However, there are a few formatting and configuration issues that need to be addressed before merging.
Issues to Fix:
1. README.md - Incomplete code block (Line 105)
The code block is missing closing backticks:
-go test ./...
+go test ./...
+```
### 2. **Missing newlines at end of files**
Please add newlines at the end of these files:
- `.github/workflows/lint.yml`
- `.github/workflows/test.yml`
- `tests/README.md`
### 3. **Go version mismatch**
The `go.mod` file specifies `go 1.24.3` which doesn't exist. This should match the CI workflows which use Go 1.21:
```diff
-go 1.24.3
+go 1.21Pick one or the other. I would match go version to ones used in the targeting velero version.
Positive Aspects:
- ✅ Excellent test documentation in
tests/README.md - ✅ Well-structured test suite with clear separation of concerns
- ✅ Good CI/CD implementation with comprehensive linting
- ✅ Clean refactoring of the non-admin directory structure
Once these formatting issues are fixed, this will be a great addition to the project!
NicholasYancey
left a comment
There was a problem hiding this comment.
Looks good, the unit test will be helpful in the near future!
k8s.io/client-go v0.33.1 → requires go 1.24.0 actions to 1.24 |
Uh oh!
There was an error while loading. Please reload this page.