Skip to content

[oadp-dev] CGO_ENABLED=1 to enable consumption of FIPS certified openssl cryptography via Red Hat golang.#28

Open
openshift-cherrypick-robot wants to merge 1 commit intomigtools:oadp-devfrom
openshift-cherrypick-robot:cherry-pick-25-to-oadp-dev
Open

[oadp-dev] CGO_ENABLED=1 to enable consumption of FIPS certified openssl cryptography via Red Hat golang.#28
openshift-cherrypick-robot wants to merge 1 commit intomigtools:oadp-devfrom
openshift-cherrypick-robot:cherry-pick-25-to-oadp-dev

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 14, 2026

This is an automated cherry-pick of #25

/assign kaovilai

Summary by CodeRabbit

  • Chores
    • Updated prebuilt binary build configuration for cross-platform distributions.

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign shawn-hurley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f46623dd-c422-4892-955b-bc625159f2a9

📥 Commits

Reviewing files that changed from the base of the PR and between e3f79f8 and b527d13.

📒 Files selected for processing (1)
  • konflux.Dockerfile

📝 Walkthrough

Walkthrough

The CGO_ENABLED flag in the Go build command for oadp-vmdp binaries was changed from 0 to 1 in the Dockerfile, enabling C bindings during cross-platform compilation while maintaining the same OS and architecture targeting parameters.

Changes

Cohort / File(s) Summary
Dockerfile Build Configuration
konflux.Dockerfile
Modified Go build invocation to enable CGO (CGO_ENABLED=1) for cross-platform oadp-vmdp binary compilation, affecting generated binaries and their checksums across all target OS/architecture combinations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From zero to one, CGO takes flight,
C bindings now weave through the build's delight,
Across every platform, from arch to arch,
Our binaries march, with libraries as their march! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: enabling CGO_ENABLED=1 for FIPS certified cryptography support, which matches the +1/-1 line change in the Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants