Skip to content

[oadp-dev] Remove execute bit from archived binaries in konflux build#29

Open
openshift-cherrypick-robot wants to merge 1 commit intomigtools:oadp-devfrom
openshift-cherrypick-robot:cherry-pick-27-to-oadp-dev
Open

[oadp-dev] Remove execute bit from archived binaries in konflux build#29
openshift-cherrypick-robot wants to merge 1 commit intomigtools:oadp-devfrom
openshift-cherrypick-robot:cherry-pick-27-to-oadp-dev

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 15, 2026

This is an automated cherry-pick of #27

/assign weshayutin

Summary by CodeRabbit

  • Bug Fixes
    • Updated executable permissions configuration on platform-specific binary artifacts during the build process to ensure correct deployment behavior across all supported environments.

The archived oadp-vmdp binaries are dormant — served for download,
not executed by ENTRYPOINT. Remove the execute bit so the payload
buildinfo check skips them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign mpryc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 06200bd3-f4a9-4f94-96a5-8c8d7ab5a9fd

📥 Commits

Reviewing files that changed from the base of the PR and between e3f79f8 and de91a14.

📒 Files selected for processing (1)
  • konflux.Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile build step that creates platform-specific binaries now removes executable permissions from downloaded /archives/oadp-vmdp_* artifacts using chmod -x, applied immediately after generating each binary and its checksum.

Changes

Cohort / File(s) Summary
Build Permissions
konflux.Dockerfile
Added chmod -x command to remove executable permissions from platform-specific binary artifacts after generation and checksum creation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A chmod here, a permission there,
Binaries stripped of their execute flair,
The Dockerfile hops along with care,
Making sure permissions are handled fair! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing execute bits from archived binaries in the konflux build process, which matches the file modifications and commit message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants