Fix iOS accessibility reading bounds and coordinates - #629
Open
at-wr wants to merge 2 commits into
Open
Conversation
at-wr
marked this pull request as ready for review
August 11, 2026 02:16
migueldeicaza
requested changes
Aug 17, 2026
migueldeicaza
left a comment
Owner
There was a problem hiding this comment.
Thank you for sending this along!
| // UIKit supplies this point in screen coordinates. Converting through | ||
| // the scroll view also accounts for its bounds origin/content offset. | ||
| let localPoint = convert(point, from: nil) | ||
| return AccessibilityReadingPolicy.lineNumber( |
Owner
There was a problem hiding this comment.
I think that accessibilityLineNumber receives screen coordinates, and the call to convert does it from window coordinates, I think this needs reviewing.
From their docs:
A point within the bounds of the receiver’s view space, in screen coordinates. That is, a point for which [self pointInside:point withEvent:event] == YES.
The "nil" to convert indicates window coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSNotFound/nil/.zerofor invalid reading-content lines instead of indexing outside the terminal bufferlayoutChangedon every terminal repaint, which can repeatedly reset VoiceOver focusRationale
Apple documents that
accessibilityLineNumber(for:)receives screen coordinates,accessibilityFrame(forLineNumber:)must return screen coordinates, and invalid line numbers return no content.layoutChangedis reserved for actual screen layout changes, not terminal cell updates.Testing
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter AccessibilityReadingPolicyTests(5 tests pass on currentmainand the 1.18.0 backport)