Fix: Restore ms[df] URI handling logic #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
requested changes
Dec 16, 2025
Collaborator
|
@vicajilau Also, once the comment is addressed, don't forget the changelog / patch version :) |
navaronbracke
approved these changes
Dec 16, 2025
Collaborator
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
LGTM! "Media Store File" and "Media Store Directory" makes way more sense now, thanks!
navaronbracke
approved these changes
Dec 16, 2025
Restricts the usage of `ACTION_PICK` to `image/*` mime types only. Replaces `ACTION_GET_CONTENT` with `ACTION_OPEN_DOCUMENT` for general file selection to ensure consistent document access.
navaronbracke
requested changes
Dec 18, 2025
Adds KDoc documentation to `startFileExplorer` methods to clarify parameters and functionality. Includes inline comments explaining the preference for `ACTION_PICK` for images and `ACTION_OPEN_DOCUMENT` for persistent URI access.
navaronbracke
approved these changes
Dec 18, 2025
Collaborator
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
One minor doc nit, but otherwise LGTM.
android/src/main/kotlin/com/mr/flutter/plugin/filepicker/FileUtils.kt
Outdated
Show resolved
Hide resolved
Collaborator
|
We can ship this, once the tests pass. |
Co-authored-by: Navaron Bracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the ms[df] URI handling logic in FileUtils.kt to fix file selection returning null on some devices. fixes #1922, fixes #1916