Skip to content

Conversation

@vicajilau
Copy link
Collaborator

Renames the FileUtils class and source files to FilePickerUtils in the iOS implementation. This includes updating the class definition, implementation, and the umbrella header import.

Fixed: #1921

Renames the `FileUtils` class and source files to `FilePickerUtils` in the iOS implementation. This includes updating the class definition, implementation, and the umbrella header import.
@navaronbracke
Copy link
Collaborator

@vicajilau I think we should evaluate if we can rewrite the plugin in Swift (using the shared darwin source option)

That would make contributing a lot easier, too.

@vicajilau
Copy link
Collaborator Author

@navaronbracke From what I can see, sharedDarwinSource only serves to unify flows on iOS and macOS. But I wouldn't mind rewriting the Objective-C code in Swift. Shall we create an issue to follow up on this?

@navaronbracke
Copy link
Collaborator

navaronbracke commented Dec 18, 2025

@navaronbracke From what I can see, sharedDarwinSource only serves to unify flows on iOS and macOS. But I wouldn't mind rewriting the Objective-C code in Swift. Shall we create an issue to follow up on this?

Correct. My suggestion is that we rewrite the MacOS portion in Swift, and unify with iOS in the same refactor.
We can follow up with a new feature request issue.

Maybe we can do that in two passes though (one Obj-C -> Swift for MacOS PR, one sharedDarwinSource:true PR)

@vicajilau vicajilau merged commit 2b63a88 into master Dec 18, 2025
9 checks passed
@vicajilau vicajilau deleted the feature/rename-FileUtils-iOS branch December 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class name conflict

3 participants