Skip to content

Various Fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Various Fixes #16

wants to merge 3 commits into from

Conversation

mrcodetastic
Copy link

@mrcodetastic mrcodetastic commented Nov 21, 2024

Excellent Library, some changes:

  • Change to 'JsonDocument' with the new ArduinoJson
  • Explicitly request HTTP 1.0 as servers that use chunking breaks HTTPClient
  • Use Arduino Streams to avoid unnecessary JSON memory allocation
  • Remove C-style string defs for WiFi Config
  • Add extra Serial Debugging for insight purposes

use streams, fix for response codes that are OK, fix for chunked encoding that breaks arduinojson
* Request HTTP 1.0 as servers that use chunking breaks HTTPClient
* Use Arduino Streams to avoid unnecessary JSON memory allocation
* Remove C-style string defs
* Add extra Serial Debugging for insight purposes
@mrcodetastic
Copy link
Author

This also includes the same fix as per #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant