-
Notifications
You must be signed in to change notification settings - Fork 9
fixed issue https://notepad-plus-plus.org/community/topic/12558 + appveyor + x64 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Any news? |
|
@mike-foster Updated appveyor.yml to use VM image VS2017 to be prepared for VS2017 builds. https://ci.appveyor.com/project/chcg/npp-session-manager/build/1.4.2.6 Is there a chance to get this merged? |
|
Any news? We need the session manager with x64 support |
|
@chcg What about tagging a new SessionManager version (1.4.3) from your repo clone containing your x64 fixes and the menu issue fix and adding the released AppVeyor artifacts (copied to your repo releases section) as plugin's binary sources in nppPluginList (both x86 and 64) ? Sadly, Mike has already commented here that he'll probably not going to support Session Manager any further. |
25cdb25 to
e13a190
Compare
… just release builds are possible by available nmake makefile - updated npp include files to v3.1 from https://github.com/npp-plugins/plugintemplate, modified PluginInterface.h to include menuCmdID.h as before - changed makefile for x64 build - updated bufferid references from INT -> LRESULT - fixed issue https://notepad-plus-plus.org/community/topic/12558/session-manager-issue by usage of fix from https://github.com/pnedev/npp-session-manager - update vesion to 1.4.3 for release
|
@pnedev https://github.com/chcg/npp-session-manager/releases/tag/v1.4.3. @mike-foster I hope you are fine with that. I would also support in bringing this update to this repo if you want.. |
|
@chcg |
|
@fade2gray Maybe we start here. Do you want to provide a PR or request a fix from my side? |
|
@chcg More a FR than an issue. Npp is able to retain a file's editing history when Npp is closed without saving the file. Can this ability be added to SessionManger? Thanks for your consideration. |
|
@fade2gray As I'm not as deep inside of the code and don't use the plugin on my own probably I will not dig into it to provide a new feature. But if somebody else is interested I could merge the change to my repo and create a new release. Sorry. |
|
@chcg OK, thanks for the feedback. |
see appveyor CI build https://ci.appveyor.com/project/chcg/npp-session-manager/build/1.4.2.5