Release: Unit Hints #2468
Merged
Release: Unit Hints #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the name of PBRMaterial is lost when calling to_simple() which causes issues when exporting meshes with named materials in obj format.
Hi @mikedh! Currently the name of PBRMaterial is lost when calling to_simple() which causes issues when exporting meshes with named materials in obj format. More specifically, the baseColorTexture will always be saved as an image with name ```material_0.png```, and I couldn't find any workaround to override this name; this means if saving two such meshes in the same directory, only the last texture image would be available. I provided the simple fix to pass the name, but please let me know if there is an alternative. Thanks for the amazing library!
This PR adds a lot of missing typing to methods and properties in the `Trimesh` class. Additionally, this PR updates a bunch of docstrings that were missing information.
- Change 3mf file used on round trip test to cover the case - Fixed by getting model id of the geometry instead of the node, if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20mm-xyz-cubedid not resolve asmm.macos-15-intelimage.trimesh.scene.lighting.autolightcrashing on empty scenes by checkingscene.bounds is Nonetrimesh.util.concatenate()#2457 toPBRMaterial.to_simpleusing the same conversion function for the linearbaseColorFactorto RGB, but don't actually apply the change as it seems likely to be a source of user confusion.Path2D.convex_hullto match every other geometry method.test_scene.pyto pytest styleLiteraltype forVoxelizationMethodsTyperather than a "loose string".