Handle 3mf partnumber #2474
Open
Handle 3mf partnumber #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstor
force-pushed
the
feat/3mf-partnames
branch
from
0f970f0 to
5d1b66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle build items' partnumber attribute on both load and export functions
Now the node names won't have unique id suffix, only an integer will be added when needed. The partnumbers will be the node names in the Scene graph, if it's better to store them separately please let me know.
While testing part number preservation, I found that the Scene class cannot keep the hierarchy of 3MF files containing multiple instances of composite parts. That’s the reason we flatten the graph during loading, isn’t it?
As a result, build items that reference composite objects are expanded into their components, causing the original part numbers to be lost and new ones to be added.
It would be cool to be able to replicate the original hierarchy, but I haven't found an easy way.