-
Notifications
You must be signed in to change notification settings - Fork 633
Refactor: Docs #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor: Docs #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the upstream packages in `[easy]` to see if they have Python 3.14 builds. Mostly we just have to bump the version of `cibuildwheel` and re-build. Ones that are done: - [python-fcl](BerkeleyAutomation/python-fcl@b41eca7) - [embreex](trimesh/embreex@0952598) - [cascadio](trimesh/cascadio#20) Ones that require a build toolchain (`apt install build-essential git`): - [mapbox-earcut](https://github.com/skogler/mapbox_earcut_python) - [xatlas](https://github.com/mworchel/xatlas-python) - [manifold3d](https://github.com/elalish/manifold) - [scikit-image](https://github.com/scikit-image/scikit-image) Had to pin two `test_more` dependencies (only used to get the test coverage up) to <3.14 - [pymeshlab](https://pypi.org/project/pymeshlab/#history) - [triangle](https://github.com/drufat/triangle/)
…watertight Instead of giving up if the whole mesh is non-watertight, only skip the components that aren't watertight.
…ertight (#2484) Instead of giving up if the whole mesh is non-watertight, only skip the components that aren't watertight. I'm having success with this on my data.
mikedh
added a commit
that referenced
this pull request
Nov 24, 2025
- release #2475 - release #2474 - release #2483 - release #2481 - release #2486 - release #2480 - this applies the March 2024 deprecation removing `Trimesh.remove_degenerate_faces` and `Trimesh.remove_duplicate_faces`. - moves the `SceneViewer` control instructions from the README to print on the `h` keypress, and make the default window caption include `h for help` - remove `psutil` from dependencies. It was only used to check if a `scipy.spatial.cdist` call was going to use more than 50% of free system memory before falling back to a more memory-efficient but slower loop. This now falls back to a looping method if the `cdist` call is going to use more than a fixed `4 GB` of memory, - add check that primitives (i.e. `Cylinder`) mostly override `area` and `volume` by checking that their primitive area/volume is not exactly floating point equal to their meshed volume. This caught that `Capsule` didn't return analytical volume/area which was also fixed. We could probably make Primitive a multiple inheritance ABC that requires certain properties but since Primitive already inherits from Trimesh that seems unnecessary and confusing. - clean up references to OpenCTM, which [was deprecated](trimesh/openctm#5) for low use, being unmaintained, and inflicting a burden on upstream package management. - docker images now build with 3.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openctmreferences reflecting the deprecationhelpersrather than being sprinkled around in the source directory.trimesh.typed.Selfhelper and change the relevant type hints.Trimesh.remove_degenerate_facesandTrimesh.remove_duplicate_faces.