Always add Net::SMTP.default_ssl_context#cert_store #1374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids users having to add settings[:ca_path] or settings[:ca_file] manually if they set #verify_mode to 'peer'
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Following up on an old PR (#1089)
I encountered the following error after setting
ActionMailer::Base.smtp_settings#openssl_verify_modeto 'peer':SSL_connect returned=1 errno=0 state=error: certificate verify failed (unable to get local issuer certificate)The way to fix this for me is manually setting the smtp_settings' ca_file, but the ca_file is an undocumented configuration parameter and thus not really clear to users.
I have now monkey patched my application with the change from this PR. Adding this as a default parameter does not harm the existing behaviour as far as I have found going through code and manual testing.