Skip to content

Add capability to register and unregister failure handlers #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-concepcion
Copy link

Failure handlers are triggered when the email fails to send and an exception is raised.

Tested against:

  • 1.8.7-p375, "mime-types-1.16" appraisal (newer specified versions of mime-types seem to require >= ruby 1.9.3)
  • 1.9.3-p551 (tested all appraisals specified)
  • 2.2.2 (tested all appraisals specified)

@ramontayag
Copy link

I worked on this with @j-concepcion. Is there anything we can do to get this merged? Do you want us to test anything else?

Failure handlers are triggered when the email fails to send and an exception
is raised.
@ramontayag
Copy link

Just updated this to 1) get it mergeable again, 2) follow the format of changelog

@jeremy
Copy link
Collaborator

jeremy commented Jan 27, 2016

Cool idea 👍

@ramontayag
Copy link

Thanks! It looks like it's failing for some other reason.

@jeremy jeremy self-assigned this May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants