[pull] main from dfinity:main#547
Merged
pull[bot] merged 3 commits intomikeyhodl:mainfrom Apr 21, 2026
Merged
Conversation
…te values (#3770) Certified attribute values were encoded as raw bytes (`Blob`) regardless of their semantic type. This changes the ICRC-3 attribute message to use the correct types: `Text` for string values (email, name), `Blob` for binary data (nonce), and `Nat` for timestamps. # Changes - `prepare_icrc3_attributes` now produces `Icrc3Value::Text` for attribute values, `Icrc3Value::Blob` for nonce, and `Icrc3Value::Nat` for timestamps instead of encoding everything as `Blob`. - `icrc3_attribute_message` accepts `BTreeMap<String, Icrc3Value>` instead of `BTreeMap<String, Vec<u8>>`. - E2e tests updated to verify correct ICRC-3 Value types in the decoded attribute map. --- <div align="left">← Previous: #3768</div> <div align="right">Next: #3791 →</div> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…ests field (#3794) The `pull_requests` field in the GitHub API's workflow runs endpoint is often empty for recent runs, causing `deploy-pr-to-beta` to fail to locate the workflow run. Query by the PR's head branch name instead, which is reliably populated. ## Test plan - [x] Verified fix resolves the issue for PR #3784 - [x] Script now successfully finds canister-tests.yml workflow runs
…3791) The ICRC-3 attribute handler previously only existed in the OpenID resume flow. Dapps using the default (non-OpenID) authorize flow that request `ii-icrc3-attributes` would get no response. This adds an ICRC-3 attributes listener to the default authorize flow's `AuthorizationChannel`. Since the user didn't authenticate via OpenID, there are no attribute values to certify — the handler responds with only the implicit entries (nonce, origin, timestamp) by calling `prepare_icrc3_attributes` with an empty attributes list. # Changes - Added `handleIcrc3AttributeRequests` to `AuthorizationChannel.svelte` that listens for `ii-icrc3-attributes`, waits for authorization + authentication, then certifies an empty attribute set. --- <div align="left">← Previous: #3770</div> <div align="right">Next: #3777 →</div> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )