feat(dev): add Justfile and pre-commit hooks #153
Conversation
Add 'ralph completions <SHELL>' command to generate shell completion scripts for bash, zsh, fish, and PowerShell. Usage: ralph completions bash > ~/.local/share/bash-completion/completions/ralph ralph completions zsh > ~/.zsh/completions/_ralph ralph completions fish > ~/.config/fish/completions/ralph.fish ralph completions power-shell > Changes: - Add clap_complete = "4.5" dependency - Create completions module with ShellArg enum - Add Completions variant to Commands enum - Wire up command handler in main.rs - Add spec documenting the feature Closes #128
Code ReviewFound 2 CLAUDE.md compliance issues: 1. Spec files in wrong directoryBoth spec files are placed in Files affected:
CLAUDE.md quote (line 97):
CLAUDE.md quote (line 240):
Fix: Move both spec files from 2. Hook installation method conflicts with CLAUDE.mdThe PR changes the hook installation method from Files affected:
CLAUDE.md quote (line 15):
The existing Fix: Either:
All other aspects of the PR (code quality, logic, security) look good. No bugs found. |
mikeyobrien
force-pushed
the
feat/devenv-setup
branch
from
4f79c69 to
4095205
Compare
…ment Replaces manual toolchain setup with devenv.sh for reproducible, cross-platform development environments. Changes: - Add flake.nix for Nix flakes support - Add devenv.nix with Rust toolchain (rustc, cargo, clippy, rustfmt) - Add devenv.yaml configuration - Add .envrc for direnv integration - Update Justfile with devenv-aware commands and ./scripts/setup-hooks.sh - Update DEVELOPMENT.md with Nix-based setup instructions and hook setup - Add specs to .ralph/specs/ (not specs/) per CLAUDE.md Features: - All contributors get identical tool versions - One command setup: direnv allow or nix develop - Pre-commit hooks via ./scripts/setup-hooks.sh (matches CLAUDE.md) - Works on Linux, macOS, and WSL Fixes: - Moved specs from specs/ to .ralph/specs/ per CLAUDE.md - Use ./scripts/setup-hooks.sh instead of git config core.hooksPath Usage: direnv allow # Auto-activate when entering directory nix develop # Or manually enter dev shell ./scripts/setup-hooks.sh # Install git hooks just check # Run all checks Refs: - CLAUDE.md line 97: specs go in .ralph/specs/ - CLAUDE.md line 15: use ./scripts/setup-hooks.sh
mikeyobrien
force-pushed
the
feat/devenv-setup
branch
from
4095205 to
c45150f
Compare
|
Fixed both CLAUDE.md compliance issues:
Thanks for the review! |
|
Closing in favor of #152 which now includes these changes. |
Adds Justfile for common dev tasks and pre-commit hooks to ensure formatting and linting before commits. Includes updated DEVELOPMENT.md with Quick Start guide.